Skip to content

Conversation

@dkropachev
Copy link
Collaborator

No description provided.

@dkropachev dkropachev requested a review from mykaul October 10, 2024 11:11
@mykaul
Copy link

mykaul commented Oct 10, 2024

LGTM - but this is just from a shallow look at this. Do we have anything else that we need ? Update the golang version?

@dkropachev dkropachev force-pushed the dk/update-gocql-version branch from c579d0f to 3550321 Compare October 10, 2024 11:18
@dkropachev
Copy link
Collaborator Author

LGTM - but this is just from a shallow look at this. Do we have anything else that we need ? Update the golang version?

There are only three dependancies, golang, sync and gocql.
sync is top version, golang - we should update only if we need a new feature, otherwise people who use this library also have to updated it.

@dkropachev dkropachev force-pushed the dk/update-gocql-version branch from 3550321 to 151802c Compare October 10, 2024 11:21
@dkropachev
Copy link
Collaborator Author

LGTM - but this is just from a shallow look at this. Do we have anything else that we need ? Update the golang version?

Can you please approve it then

@dkropachev dkropachev merged commit f06bbb2 into master Oct 10, 2024
@dkropachev dkropachev self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants